Results 1 to 7 of 7

Thread: Be great if you fixed all your themes to validate

  1. #1
    Forum Member dfavor's Avatar
    Join Date
    Dec 2011
    Location
    United States
    Posts
    5
    Thanks
    0
    Thanked 0 Times in 0 Posts

    Be great if you fixed all your themes to validate

    Some of my clients have applications which lend themselves well to your themes.

    First thing I always do vetting themes is run them through the http://validator.w3.org to see if the HTML is valid.

    Several of your themes are throwing ugly errors that will interfere with likely interfere with SEO + just shouldn't exist in premium themes.

    Let me know if there are any plans to fix the broken HTML in your themes.

    Thanks!

  2. #2
    pepsi's Avatar
    Join Date
    Mar 2009
    Location
    New Zealand
    Posts
    14,883
    Thanks
    91
    Thanked 804 Times in 718 Posts
    If you can please advise specifically which themes you have concerns with I can check our internal ticketing system for mention of reported issues/fixes. Thanks.

  3. #3
    Forum Member dfavor's Avatar
    Join Date
    Dec 2011
    Location
    United States
    Posts
    5
    Thanks
    0
    Thanked 0 Times in 0 Posts
    Here's an example... taskerr is using deprecated/obsolete HTML, which will likely be a negative SEO ranking signal. Also heading flow is broken (syntax invalid), likely because of this too...

    http://validator.w3.org/check?uri=ht...Inline&group=0

    Pages should validate like this...

    http://validator.w3.org/check?uri=da...Inline&group=0

    With two warnings.

    1) one for using HTML5 (best SEO signal)

    2) one for passing charset via Apache instead of at document level, which is required to speed up IE rendering

    - - - Updated - - -

    Vantage is even worse, with 40 errors + 18 warnings...

    http://validator.w3.org/check?uri=http%3A%2F%2Fdemos.appthemes.com%2Fvanta ge&charset=%28detect+automatically%29&doctype=Inli ne&group=0

    Because your themes use <hgroup> (deprecated) instead of <header> is part of the reason.

    Another problem is your themes break semantic structure, meaning tags placed which break the the HTML spec...

    Like <div> tags inside <hgroup> which is incorrect syntax.

    - - - Updated - - -

    Jobroller is 19 errors + 10 warnings...

    http://validator.w3.org/check?uri=http%3A%2F%2Fdemos.appthemes.com%2Fjobro ller%2F&charset=%28detect+automatically%29&doctype =Inline&group=0

    In short, probably best to add an item to your release process to run all parent themes + child themes + plugins (that generate HTML) through the W3C validator to ensure clean code before release.

    Also best to turn on full WP debug + ensure there are no WP errors... by adding this to your wp-config.php file...

    define('WP_DEBUG', true);
    define('WP_DEBUG_LOG', true);
    define('WP_DEBUG_DISPLAY', false);
    @ini_set('display_errors', 0);

    - - - Updated - - -

    These are all things that smart clients look at when vetting code to run on high traffic sites.

  4. #4
    pepsi's Avatar
    Join Date
    Mar 2009
    Location
    New Zealand
    Posts
    14,883
    Thanks
    91
    Thanked 804 Times in 718 Posts
    Thanks, I'll seek further information and will respond asap.

  5. #5
    pepsi's Avatar
    Join Date
    Mar 2009
    Location
    New Zealand
    Posts
    14,883
    Thanks
    91
    Thanked 804 Times in 718 Posts
    There are no plans at this stage to make any changes as the themes aren't considered in need of fixing. There are some references Here, here and here which may help explain our teams stance on this a bit further. Thanks.

  6. #6
    Forum Member dfavor's Avatar
    Join Date
    Dec 2011
    Location
    United States
    Posts
    5
    Thanks
    0
    Thanked 0 Times in 0 Posts
    A ridiculous answer.

    Any marginally competent coder can produce clean HTML in their themes + plugins.

  7. #7
    pepsi's Avatar
    Join Date
    Mar 2009
    Location
    New Zealand
    Posts
    14,883
    Thanks
    91
    Thanked 804 Times in 718 Posts
    I've clarified this further with our developers and understand that each theme will be reviewed and fixed accordingly, sorry for any misunderstanding. Thanks.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Similar Threads

  1. How to validate new ads on vantage ?
    By express in forum Report Vantage Bugs (Legacy)
    Replies: 3
    Last Post: June 29th, 2012, 05:08 AM
  2. [MOD NEEDED] Validate Location by State
    By koldsnapz in forum JobRoller General Discussion
    Replies: 9
    Last Post: January 7th, 2012, 02:55 PM
  3. Validate a custom form field?
    By tyles2 in forum ClassiPress General Discussion
    Replies: 0
    Last Post: July 16th, 2010, 06:14 PM
  4. Great Design-Great Ideas.
    By marco2 in forum ClassiPress General Discussion
    Replies: 0
    Last Post: November 15th, 2009, 01:32 PM